Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod by an interval #178

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Mod by an interval #178

wants to merge 7 commits into from

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Jul 9, 2018 •
edited
Loading

This builds on #145 but provides mod by an interval.

It seems to me that X mod a makes sense only if a is a positive, atomic (or thin) interval. What do you think, @lbenet?

@petvana
Copy link
Contributor

petvana commented May 24, 2022 •
edited
Loading

I just came across mod as well and implemented a simplified version mod(x::Interval, m::Real). Would it be possible to merge at least the not extended version? Is there anything I can help with?

@lbenet
Copy link
Member

lbenet commented May 24, 2022

Thanks @petvana for taking a look on this.

This PR (as well as #145) are so outdated (hence the conflicts) that the easiest might be to start a new PR from the current master, and either cherry-pick or directly adapt the code to avoid the conflicts. Would you have the time to submit a new PR?

@petvana petvana mentioned this pull request May 24, 2022
Merged
@OlivierHnt OlivierHnt mentioned this pull request Jan 29, 2024
Closed
@lbenet lbenet mentioned this pull request Mar 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpsanders @petvana @lbenet